They will last forever.
Solomon equates “forever” with “as long as the sun” continues. So does God, who also says something will be established forever like the moon. The Bible says God established the sun and moon for ever and ever, with a decree that will never pass away.
There’s also a verse in Isaiah that says Jerusalem’s sun will never set again, and its moon will wane no more.
Then they will be destroyed?
The verse just before that in Isaiah, though, makes it sound like it might actually be talking about God, not the actual sun and moon. And in any case, that verse says at that time the sun and moon will no longer shine on Jerusalem.
But won’t they still exist forever, even if Jerusalem is cut off from them somehow? No, Joel says by the time the day of the Lord arrives, the sun and moon will be darkened. The sun will turn to darkness and the moon will turn to blood. And Revelation says after the sun turns black and the moon turns red, an angel will darken a third of both of them.
Then they will still exist.
Apparently they won’t be completely destroyed at this point, because after that a woman will wear the sun and put her feet on the moon. And an angel will even make the sun more powerful.
And then they won’t be needed.
Then there’s the new Jerusalem, which won’t need the sun or moon either.
Possible explanation
Can all of these things be true? Maybe the sun and moon will exist forever, although they will turn dark, the moon will turn to blood, and not every city will need them. That seems pretty pointless. Do you think that’s what God meant when he promised that the sun and moon would never set on Jerusalem—that there will always be a dark, useless sun and moon above it?